-
-
Notifications
You must be signed in to change notification settings - Fork 691
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* when terrain is on render last layer correct, fixes #1124 * Added test to verify the bug * Fix lint Co-authored-by: HarelM <harel.mazor@gmail.com>
- Loading branch information
1 parent
6a9d9cc
commit b280511
Showing
2 changed files
with
42 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import RenderToTexture from './render_to_texture'; | ||
import type Painter from './painter'; | ||
import type LineStyleLayer from '../style/style_layer/line_style_layer'; | ||
import type SymbolStyleLayer from '../style/style_layer/symbol_style_layer'; | ||
|
||
describe('render to texture', () => { | ||
test('should render text after a line by not adding the text to the stack', () => { | ||
const painterMock = { | ||
style: { | ||
terrain: { | ||
sourceCache: { | ||
getRenderableTiles: () => [], | ||
removeOutdated: () => {} | ||
}, | ||
clearRerenderCache: () => {} | ||
}, | ||
_order: [] | ||
} | ||
} as any as Painter; | ||
const uut = new RenderToTexture(painterMock); | ||
const lineLayer = { | ||
id: 'maine-line', | ||
type: 'line', | ||
source: 'maine' | ||
} as LineStyleLayer; | ||
const symbolLayer = { | ||
id: 'maine-text', | ||
type: 'symbol', | ||
source: 'maine', | ||
layout: { | ||
'text-field': 'maine', | ||
'symbol-placement': 'line' | ||
} | ||
} as any as SymbolStyleLayer; | ||
|
||
expect(uut.renderLayer(lineLayer)).toBeTruthy(); | ||
painterMock.style._order = ['maine-line', 'maine-text']; | ||
painterMock.currentLayer = 1; | ||
expect(uut.renderLayer(symbolLayer)).toBeFalsy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters