Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use lower camel case for enum fields and consts #415

Merged
merged 8 commits into from
Jun 2, 2024

Conversation

josxha
Copy link
Collaborator

@josxha josxha commented May 17, 2024

Lower camel case is the preferred naming convention for constants and enum fields.
This pull request is breaking.

@josxha josxha changed the title feat!: use camel case for enum fields and consts feat!: use lower camel case for enum fields and consts May 17, 2024
@josxha josxha self-assigned this May 20, 2024
@kuhnroyal
Copy link
Collaborator

This can go into a 0.20.0 release. Is there a lint that we can enable for this?

@kuhnroyal kuhnroyal added this to the v0.20.0 milestone May 21, 2024
@josxha
Copy link
Collaborator Author

josxha commented May 21, 2024

Is there a lint that we can enable for this?

It might be possible to create decrecations for the old enum fields. Would require some temporary code though.

@kuhnroyal
Copy link
Collaborator

I think thats overkill but the disabled lint in analysis_options ca be enabled with this change?

@josxha
Copy link
Collaborator Author

josxha commented May 21, 2024

Ohh you're right, totally forgot about that!
Update: fixed

@josxha josxha requested a review from kuhnroyal May 29, 2024 17:37
@kuhnroyal kuhnroyal merged commit adb1303 into maplibre:main Jun 2, 2024
9 checks passed
@josxha josxha deleted the clean/part4 branch June 2, 2024 10:50
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 6, 2024
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants