Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check to layer#setVisibility on Android #374

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

polylina
Copy link
Contributor

In our app there is a possibility to switch between map layers, and the amount of layers varies over time. In some cases, this leads to a NullPointerException in the current version of the library on Android. This PR fixes it. The iOS code has null checks implemented already.

Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting the fix!

@m0nac0 m0nac0 enabled auto-merge (squash) January 28, 2024 12:19
@m0nac0 m0nac0 merged commit 6eb2718 into maplibre:main Jan 28, 2024
6 checks passed
ManoyloK pushed a commit to ManoyloK/flutter-maplibre-gl that referenced this pull request Feb 6, 2024
In our app there is a possibility to switch between map layers, and the
amount of layers varies over time. In some cases, this leads to a
NullPointerException in the current version of the library on Android.
This PR fixes it. The iOS code has null checks implemented already.

Co-authored-by: Polina Gurina <p.gurina@icloud.com>
@josxha josxha added this to the v0.19.0 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants