-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping: Improve docs and update outdated references to point to MapLibre #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does quite some housekeeping in updating outdated references from mapbox to maplibre, mostly in doc comments in the web sub-package.
This obviously seems like a quite huge PR, but I think for the review it is sufficient to take a short look at the simple renamings (they are in separate commits and were done with IDE tooling) and maybe a cursory look at the doc comments.
The web documentation changes are quite unspectacular and probably barely anyone ever looks at the web-plugin docs, but I think we needed to do this housekeeping at some point.
updated documentation:
the only "code changes" are a couple of (simple) renamings:
All renamings were done only with the IDE renaming function. There are no functional changes and no changes in the public API, only some internal renamings and updated doc comments. (This can also be seen by the fact that the example app needs no updates, only two internal variables were renamed).
Nearly all remaining references to mapbox are in the android or ios directories.