-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS example: pin pod versions #276
Conversation
I want to add new pod versions of the MapLibre pod (m0nac0/flutter-maplibre-podspecs#2). I think it's a good idea to pin the MapLibre native version here and then explicitly update it after we have tested the new MapLibre native version.
pod 'MapLibre', '5.12.2' | ||
pod 'MapLibreAnnotationExtension', '0.0.1-beta.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed MapLibreAnnotationExtension
in #277 and pinned it to 5.14.0-pre1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that remove MapLibreAnnotationExtension
and add it back once we have a flutter api that uses which is not the case right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuhnroyal Do you have some insight into whether developers still need to list the dependency in their podfile like we do in the example app, and if yes, is there some way we can tell Flutter to automatically add it to their Podfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MapLibre
is available in cocaopods trunk (which it seems to be: https://github.com/CocoaPods/Specs/tree/master/Specs/b/0/0/MapLibre) and MapLibreAnnotationExtension
is removed, then there is no need to specify anything manually.
If MapLibreAnnotationExtension
is required again in the future, then it should also be published via cocoapods and then no manual listing is required either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that sounds good. So I'll close this PR and open a new one to remove these lines.
I want to add new pod versions of the MapLibre pod (m0nac0/flutter-maplibre-podspecs#2).
I think it's a good idea to pin the MapLibre native version here and then explicitly update it after we have tested the new MapLibre native version.