Fix crash android dispose nullpointerdereference #203

GaelleJoubert · 2023-02-23T14:29:58Z

Fix issue #182

Fix issue maplibre#182 I took the file from the fix from mapBox (this one), and add it at the same place in maplibre. It seems to fix the issue ! At least I have not mannage to make it happen again.

…dereference

…ence

m0nac0 · 2023-02-25T14:58:06Z

Thank you for contributing this!
I assume this was copied from https://github.com/flutter-mapbox-gl/maps?

If so, I think we should fully port both flutter-mapbox-gl/maps#1172 and flutter-mapbox-gl/maps#1217 which introduced/improved this fix over there (and contain a few other changes as well).

GaelleJoubert · 2023-02-27T09:15:19Z

Yes, as I mentionned in the issue #182 , I copied this file, from the MapBox library.
This file was added in flutter-mapbox-gl/maps#1217 .

I have not check the rest :)

mariusvn · 2023-02-28T16:29:47Z

can you flutter format the code and try to fix the warnings ?

edit to fix warnings

format

GaelleJoubert · 2023-02-28T16:47:53Z

I try to format automatically the code, but it did not change the warning :/
Same with the static code analysis errors .. no idea how to fix them, on my side I have no errors ..
Any idea what to do ?

m0nac0 · 2023-03-01T08:03:46Z

I haven't looked at in detail, but I assume this is because we need to port all changes from flutter-mapbox-gl/maps#1172 and flutter-mapbox-gl/maps#1217.

reproduced fix #1172 step 1

Copy Fix #1172 step2

m0nac0 · 2023-03-01T09:12:54Z

README.md

@@ -147,6 +147,11 @@ buildTypes {
 }
 ```

+## Flutter 3.x.x issues
+Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or Mapbox fix this issue properly. Use with caution.


Suggested change

Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or Mapbox fix this issue properly. Use with caution.

Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or MapLibre fix this issue properly. Use with caution.

GaelleJoubert · 2023-03-01T09:14:08Z

I am porting all the changes at the moment :)

GaelleJoubert · 2023-03-01T09:55:30Z

Ok, I finnaly fixed all the warning, this is ready to merge.

GaelleJoubert · 2023-03-01T10:17:00Z

I have tried it on my maps.
I still have the issue sometimes, but less often than before.
So It is not a complete fix, but it is still an improvement.
So I think it still worth it to merge it.
And once it will be merge with all the other recent fix, I'll test it again.

GaelleJoubert · 2023-03-01T10:55:30Z

By the way, I found a nice workaround to avois the crash.
Since it happens at the Dispose() of the map, if you wrap the page where you have the MapLibre() widget in a KeepAlive, then dispose is never called when changing page, and the app does not crash.

Exemple of code :

class MapWidgetWithMarker extends StatefulWidget {
  MapWidgetWithMarker();
  @override
  _MapWidgetWithMarkerState createState() => _MapWidgetWithMarkerState();
}

class _MapWidgetWithMarkerState extends State<MapWidgetWithMarker> with AutomaticKeepAliveClientMixin  {

 @override
  Widget build(BuildContext context)   {

    return MaplibreMap( 
    //all your options
    );
  }

@override
  bool get wantKeepAlive => true;

}

Should I add that to the Readme, in Fix frequent errors ?

mariusvn · 2023-03-01T11:12:35Z

with AutomaticKeepAliveClientMixin, is the maplibre instance being recreated when reopening the widget ?

GaelleJoubert · 2023-03-01T11:36:15Z

with AutomaticKeepAliveClientMixin, is the maplibre instance being recreated when reopening the widget ?

If I understand correctly, no It is not, it is the same that was created the first time.
I tested it with my app and it works perfectly.
The way my app works is the following :
I have a Scaffold wiith a PageView that handle 3 pages, and Bottom AppBar to navigate these pages.
One of this page is a MapLibre.
Before, when I switched between the pages, I had a crash.
The fix of this PR reduced the occurence of the crash (it use to be all the time, now it's maybe 1/5 time in average.
With the AutomaticKeepAlaive workaround, I don't have anymore crashes, as the page with the map is always the same instance.

I also use other MapLibre instance in some pop up or preview in other pages, but these one did not cause crash, and I did not wrap them in KeppAlives.

I think I have the crash at dispose because each time I switch page the page view rebuild and sipose all pages, and do that too fast, and that cause the crash.

allou-deyforyou · 2023-03-04T14:44:55Z

Hey, You have found a solution.

GaelleJoubert · 2023-03-27T12:34:56Z

@mariusvn Hi, did you have any time to check (and update?) the CI that build the apk ?
I've try but I did not figure it out ... this is the last thing preventing this PR to be merge (in my side it builds and works fine. )

GaelleJoubert · 2023-03-27T12:35:12Z

@mariusvn Hi, did you have any time to check (and update?) the CI that build the apk ?
I've try but I did not figure it out ... this is the last thing preventing this PR to be merge (in my side it builds and works fine. )

mariusvn · 2023-03-27T13:49:44Z

we need to update the dependencies (old versions are in the pubspec.lock) by executing flutter pub upgrade.
I cannot write to your PR so you must do it.

GaelleJoubert · 2023-03-27T14:13:45Z

we need to update the dependencies (old versions are in the pubspec.lock) by executing flutter pub upgrade. I cannot write to your PR so you must do it.

Thanks for the tips ! I'll do it by tomorrow :)

mariusvn · 2023-03-27T14:27:44Z

i was talking of a flutter upgrade not, updating the pubspec.yaml. You should rollback your last changes because the dependencies upgrade in pubspec.yaml should be done in a separate PR.
The only file who should change is the pubspec.lock (the only thing to do is flutter pub upgrade)

GaelleJoubert · 2023-03-27T14:35:26Z

ok ok, I'll revert the changes.
So the only thing to do is to open the flutter console where my local repo maplibre is and run the command flutter pub upgrade, is that it ?

This reverts commit 7acbedd.

This reverts commit 7b5caad.

mariusvn · 2023-03-27T14:39:50Z

yep should be

mariusvn · 2023-03-27T14:43:00Z

hmm it looks like it didn't pass but it works on my side after the upgrade, i wait till the end of the android and i'll check

GaelleJoubert · 2023-03-27T14:44:14Z

Ok, I just ran "flutter pub upgrade", but it looks like it is not enough ...

Here is the result of it in my console, if it helps :

C:\Users\GaelleJoubert\StudioProjects\flutter-maplibre-gl>flutter pub upgrade
Resolving dependencies...
> archive 3.3.6 (was 3.1.2)
  characters 1.2.1 (1.3.0 available)
  collection 1.17.0 (1.17.1 available)
+ convert 3.1.1
> crypto 3.0.2 (was 3.0.1)
  flutter 0.0.0 from sdk flutter
  flutter_web_plugins 0.0.0 from sdk flutter
> image 3.3.0 (was 3.0.2) (4.0.15 available)
  js 0.6.5 (0.6.7 available)
  maplibre_gl_dart 0.2.2 from git https://github.com/m0nac0/maplibre-gl-dart.git at 24a48e
! maplibre_gl_platform_interface 0.16.0 from path maplibre_gl_platform_interface (overridden)
! maplibre_gl_web 0.16.0 from path maplibre_gl_web (overridden)
  material_color_utilities 0.2.0 (0.3.0 available)
  meta 1.8.0 (1.9.1 available)
> path 1.8.3 (was 1.8.0)
> petitparser 5.1.0 (was 4.1.0) (5.3.0 available)
+ pointycastle 3.7.2
  sky_engine 0.0.99 from sdk flutter
> typed_data 1.3.1 (was 1.3.0)
  vector_math 2.1.4
> xml 6.2.2 (was 5.1.0)
Warning: You are using these overridden dependencies:
! maplibre_gl_platform_interface 0.16.0 from path maplibre_gl_platform_interface
! maplibre_gl_web 0.16.0 from path maplibre_gl_web
Changed 9 dependencies!
7 packages have newer versions incompatible with dependency constraints.

mariusvn · 2023-03-27T14:53:46Z

Can you flutter upgrade before doing flutter pub upgrade ? maybe you're not on the last version of flutter (not sure if it will resolve the problem)

GaelleJoubert · 2023-03-27T14:58:52Z

I just did that but It did not changed anything :

(I did flutter upgrade before this command, but I was already up to date)

GaelleJoubert · 2023-03-27T15:03:12Z

Can you flutter upgrade before doing flutter pub upgrade ? maybe you're not on the last version of flutter (not sure if it will resolve the problem)

But From what I understand, the CI does not use my local version of flutter to build the APK.
(It all work well locally on my side).

But it use subosito, as we can see in the workflow file. It looks like the "not up to date" comes from the workflow library ...

Try to change flutter ci according to exemple given by subosito

GaelleJoubert · 2023-03-27T15:27:01Z

@mariusvn I try to edit flutter ci according to the subosito exemple, but no success here. @m0nac0 any idea what's wrong and how to fix the issue ?
It builds well on both mine and Marius local branch, but it does not build in the CI ...

m0nac0 · 2023-03-27T15:39:54Z

example/pubspec.lock

    source: hosted
    version: "1.2.1"
  file:
    dependency: transitive
    description:
      name: file
-      url: "https://pub.dartlang.org"
+      sha256: b69516f2c26a5bcac4eee2e32512e1a5205ab312b3536c1c1227b2b942b5f9ad
+      url: "https://pub.dev"
    source: hosted
    version: "6.1.2"


I think we may need to upgrade the file plugin version of the example app. But we shouldn‘t do this manually here in the pubspec.lock file. Have you tried running flutter pub upgrade in the example directory (not the project root) and committed/pushed the changes to example/pubspec.lock?

Youhou ! Looks like it was that !!
I ran pub upgrade in the exemple directory (and not the project root), and it worked !! :D
Finnally !!

m0nac0 · 2023-03-27T15:40:34Z

The CI uses flutter 3.7.7, is that what you are using?

I think the issue is that version 6.1.2 of the file plugin is used in the example app, but there was a breaking change of sorts in version 6.1.3 https://pub.dev/packages/file/changelog

GaelleJoubert · 2023-03-27T16:57:55Z

@m0nac0 ready to be merged, finnaly !

…ence

Fix issue maplibre#182 --------- Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>

GaelleJoubert and others added 3 commits February 23, 2023 15:29

Fix issue maplibre#182

5ae729d

Fix issue maplibre#182 I took the file from the fix from mapBox (this one), and add it at the same place in maplibre. It seems to fix the issue ! At least I have not mannage to make it happen again.

Merge branch 'm0nac0:main' into fix-crash_android_dispose_nullpointer…

e0da249

…dereference

Merge branch 'main' into fix-crash_android_dispose_nullpointerderefer…

509292a

…ence

GaelleJoubert added 2 commits February 28, 2023 17:36

Update view_wrappers.dart

1191c77

edit to fix warnings

Update view_wrappers.dart

2d5da2f

format

GaelleJoubert and others added 3 commits March 1, 2023 09:17

Update maplibre_gl_platform_interface.dart

03e6f77

reproduced fix #1172 step 1

Update method_channel_mapbox_gl.dart

fcad1e8

Copy Fix #1172 step2

Copy all fix from #1172 in mapbox

cac3118

m0nac0 reviewed Mar 1, 2023

View reviewed changes

Fix #1217 from map box

19be7f8

GaelleJoubert added 8 commits March 1, 2023 10:22

Fix errors

b1a3778

Fix name

e077ecc

format

7722ae8

fix unnecessary cast

80b93e8

fix override

d4307cb

try fix cast

63976ca

try fix cast 2

13b3b7b

format

87176d4

upgrade dependencies

7b5caad

upgrade dependencies

7acbedd

GaelleJoubert added 3 commits March 27, 2023 16:35

Revert "upgrade dependencies"

adad070

This reverts commit 7acbedd.

Revert "upgrade dependencies"

bb9ab87

This reverts commit 7b5caad.

run : flutter pub upgrade

71b2f35

GaelleJoubert and others added 2 commits March 27, 2023 17:13

Update flutter_ci.yml

730f2d4

Try to change flutter ci according to exemple given by subosito

Try other config of flutter ci

634986d

m0nac0 reviewed Mar 27, 2023

View reviewed changes

revert update flutter ci commit and upgrade flutter pub in exemple file

ff8da76

Merge branch 'main' into fix-crash_android_dispose_nullpointerderefer…

3ffa639

…ence

m0nac0 enabled auto-merge (squash) April 4, 2023 17:13

m0nac0 merged commit ee82380 into maplibre:main Apr 4, 2023

m0nac0 mentioned this pull request Apr 4, 2023

Android app crashes with null pointer dereference exception #182

Closed

JulianBissekkou mentioned this pull request Jun 16, 2023

[Help wanted] Review code smell in view_wrappers.dart #255

Open

JanikoNaber pushed a commit to JanikoNaber/flutter-maplibre-gl that referenced this pull request Aug 23, 2023

Fix crash android dispose nullpointerdereference (maplibre#203)

8eec27b

Fix issue maplibre#182 --------- Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash android dispose nullpointerdereference #203

Fix crash android dispose nullpointerdereference #203

GaelleJoubert commented Feb 23, 2023

m0nac0 commented Feb 25, 2023 •

edited

Loading

GaelleJoubert commented Feb 27, 2023

mariusvn commented Feb 28, 2023

GaelleJoubert commented Feb 28, 2023

m0nac0 commented Mar 1, 2023

m0nac0 Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

mariusvn commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

allou-deyforyou commented Mar 4, 2023

GaelleJoubert commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023 •

edited

Loading

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023 •

edited

Loading

GaelleJoubert commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

m0nac0 Mar 27, 2023

GaelleJoubert Mar 27, 2023

m0nac0 commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

	Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or Mapbox fix this issue properly. Use with caution.
	Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or MapLibre fix this issue properly. Use with caution.

Fix crash android dispose nullpointerdereference #203

Fix crash android dispose nullpointerdereference #203

Conversation

GaelleJoubert commented Feb 23, 2023

m0nac0 commented Feb 25, 2023 • edited Loading

GaelleJoubert commented Feb 27, 2023

mariusvn commented Feb 28, 2023

GaelleJoubert commented Feb 28, 2023

m0nac0 commented Mar 1, 2023

m0nac0 Mar 1, 2023

Choose a reason for hiding this comment

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

mariusvn commented Mar 1, 2023

GaelleJoubert commented Mar 1, 2023

allou-deyforyou commented Mar 4, 2023

GaelleJoubert commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023 • edited Loading

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

mariusvn commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023 • edited Loading

GaelleJoubert commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

m0nac0 Mar 27, 2023

Choose a reason for hiding this comment

GaelleJoubert Mar 27, 2023

Choose a reason for hiding this comment

m0nac0 commented Mar 27, 2023

GaelleJoubert commented Mar 27, 2023

m0nac0 commented Feb 25, 2023 •

edited

Loading

mariusvn commented Mar 27, 2023 •

edited

Loading

GaelleJoubert commented Mar 27, 2023 •

edited

Loading