Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow receiver to set the visibility of a layer #134

Closed
wants to merge 4 commits into from
Closed

feat: allow receiver to set the visibility of a layer #134

wants to merge 4 commits into from

Conversation

TimAlber
Copy link
Contributor

Add a feature to let the receiver to set the visibility of a layer.

@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 29, 2022

Thank you for contributing hits, I've actually implemented the same feature a few days ago in the m0-toggle-vis branch, we should compare if there are any advantages to either implementation.

@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 29, 2022

Our implementations are very similar, differences are

@TimAlber
Copy link
Contributor Author

It is fine by me to use your implementation.
I will close my PR when yours is merged in.

@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 29, 2022

Sorry about the duplication of effort ;)

@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 31, 2022

Closing since this has been implemented in #138

@m0nac0 m0nac0 closed this Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants