Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxzoom, minzoom, scheme #38

Merged
merged 4 commits into from
May 8, 2018
Merged

maxzoom, minzoom, scheme #38

merged 4 commits into from
May 8, 2018

Conversation

GretaCB
Copy link
Contributor

@GretaCB GretaCB commented May 2, 2018

Per #36, and branched from #37 to avoid huge conflicts.

This PR also adds clarification around "Default" values

cc @mapsam

3.0/README.md Outdated

OPTIONAL. Default: 0. >= 0, <= 30.

An integer specifying the minimum zoom level.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since maxzoom has "MUST be >= minzoom" do we want to include the same for minzoom? "MUST be <= maxzoom"

3.0/README.md Outdated
Implementations MUST treat unknown keys as if they weren't present. However, implementations MUST expose unknown key/values in their API so that API users can optionally handle these keys. Implementations MUST treat invalid values for keys as if they weren't present. If the key is required, implementations MUST treat the entire TileJSON manifest file as invalid and refuse operation.
Implementations MUST treat unknown keys as if they weren't present. However, implementations MUST expose unknown key/values in their API so that API users can optionally handle these keys. Implementations MUST treat invalid values for keys as if they weren’t present. If the the field is an optional field and the value is invalid, the default value MAY be applied. If the key is required, implementations MUST treat the entire TileJSON manifest file as invalid and refuse operation.

Default`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a TODO to leave a note about "default" values @GretaCB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, thanks @mapsam . I'll clean up

@mapsam mapsam mentioned this pull request May 7, 2018
41 tasks
@GretaCB GretaCB merged commit df1abd9 into 3.0 May 8, 2018
@GretaCB GretaCB deleted the 3.0-zoom-scheme branch May 8, 2018 19:03
mapsam added a commit that referenced this pull request Aug 18, 2021
* 3.0 skeleton

* name, tilejson, version, description

* bounds first draft

* MAY assume

* update version major example

* maxzoom, minzoom, scheme (#38)

* zooms, scheme, adds default value info, and adds minzoom MUST value

* tiles (#40)

* Add tiles field, and add clarification around extensions used

* Add center field

* data section

* copy over grids

* legend

* template

* fix line break

* Per pnorman's suggestions

* full semver versioning

* Update directory name based on valid semver versioning

* Forgot to delete the old dir

* RFC 8259 is the current JSON spec (#47)

RFC 8259 has obsoleted RFC 7159, which obsoleted RFC 4267.

Only significant difference from RFC 4267 is that it disallows UTF-16 and UTF-32 encodings for JSON and mandates UTF-8 only.

I've also switched the IETF links to the HTML versions and changed "WGS:84" to "WGS 84".

* add fillzoom

* quick updates from @springmeyer

* clarify data field usage

* vector_layers (#42)

* Expand on empty fields object, provide example, and add subsections

* 3.0 notes and updates (#52)

* Add note on grid interactivity

* Ensure integers are integers in the examples

* Consistify use of TileJSON and consistify fillzoom json example with the spec description

* Ensure tile endpoints are absolute urls

* Use set of tiles instead of tileset

* keys and values

* update section order & put required first

* add extra note about bounds of one dimension

* define implementation

* add caching, schema.json

* add osm.json example

* add examples link

* fix link

* add data types, some review updates

* final edits

* update CHANGELOG'

* update README and changelog

Co-authored-by: Carol Hansen <carol@mapbox.com>
Co-authored-by: Sean Gillies <sean.gillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants