Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sharp instead of mapnik #2

Open
riastrad opened this issue Apr 28, 2020 · 1 comment
Open

use sharp instead of mapnik #2

riastrad opened this issue Apr 28, 2020 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@riastrad
Copy link

Currently, in order to do the final blending/cropping of Static Tiles, this library uses node-mapnik. This is a pretty beefy dependency to include solely for that purposes, it would potentially be better to use something written primarily for the purpose. After a bit of research, I would be happy with porting it to sharp, which has comparable features and is a bit lighter weight.

cc/ @tristen

@riastrad riastrad added the enhancement New feature or request label Apr 28, 2020
riastrad pushed a commit that referenced this issue Apr 30, 2020
stop gap to ensure node v10 compatibility until I can land #2
@riastrad
Copy link
Author

riastrad commented May 22, 2020

I had a little bit of slack in my schedule so I started messing around with Sharp over in quilt@riastrad/looking-sharp.

Unfortunately, it wasn't a super straightforward implementation because sharp's composite operation does not allow you to use top & left placement values that are outside the bounds of the final image you are generating (like we currently do with mapnik).

Ultimately, this would require a bigger refactor of quilt's image compositing logic than I'm willing to commit to at the moment.

@riastrad riastrad added the wontfix This will not be worked on label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant