This repository has been archived by the owner on Apr 10, 2018. It is now read-only.
Drop paint classes #576
Merged
Drop paint classes #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Should |
|
Let's not create |
|
👍 sounds good. Shall we keep |
jfirebaugh
suggested changes
Nov 17, 2016
| Layers can also have class-specific paint properties, which are applied only when the map has a certain class | ||
| name set. For example, a layer with a <code>"paint.night"</code> property would have those properties applied | ||
| when the map has the <code>"night"</code> class set. | ||
| Layers can also have class-specific paint properties, defined with a property like <code>"paint.night"</code> and applied only when the map has a certain class |
There was a problem hiding this comment.
Let's just remove this.
| @@ -60,6 +107,29 @@ fs.writeFileSync('./dest.min.json', format(style, 0)); | |||
| **Returns** `string`, stringified formatted JSON | |||
|
|
|||
|
|
|||
| ### `exports(layers)` | |||
There was a problem hiding this comment.
Can you fix the naming like you did with derefLayers? Should be groupByLayout.
| function eachLayer(style, callback) { | ||
| for (var k in style.layers) { | ||
| callback(style.layers[k]); | ||
| eachLayer(style.layers[k], callback); |
There was a problem hiding this comment.
This shouldn't be recursive.
|
@jfirebaugh ^ changes made. Back to you. |
jfirebaugh
approved these changes
Nov 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8.jsonand narrative docs.v9.json, and removepaint.*.migrations/v9with deref & declass functionality.