Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Map::isFullyLoaded should be called Map::isLoaded #3318

Closed
wants to merge 1 commit into from

Conversation

brunoabinader
Copy link
Member

This matches Style, Source and GL JS.

/cc @jfirebaugh

@jfirebaugh
Copy link
Contributor

It looks like this changes the iOS public API. The backward incompatibility there is probably not worth the naming consistency.

cc @1ec5

@1ec5
Copy link
Contributor

1ec5 commented Dec 16, 2015

-[MGLMapView isFullyLoaded] is actually a private method that the ios-bench application redeclares for its own use in waiting for assets to load. It’s a hack, and I don’t think this change would impact iOS SDK versioning at all.

@kkaefer, can MBXBenchViewController make use of -[MGLMapViewDelegate mapViewDidFinishRenderingMap:fullyRendered:] instead, or would #1804 turn out to be a blocker?

@brunoabinader
Copy link
Member Author

Closing due to ongoing terminology discussions.

@brunoabinader brunoabinader deleted the 3318-map-is-loaded branch December 18, 2015 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants