Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] A more accurate algorithm for approximating round line joins #15089

Merged
merged 1 commit into from
Aug 5, 2019
Merged

[core] A more accurate algorithm for approximating round line joins #15089

merged 1 commit into from
Aug 5, 2019

Conversation

alexshalamov
Copy link
Contributor

@alexshalamov alexshalamov commented Jul 10, 2019 •
edited by tmpsantos
Loading

@alexshalamov
Copy link
Contributor Author

/cc @mourner

mourner
mourner approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Let's wait for the original PR to get reviewed by @ansis before merging though.

@friedbunny friedbunny added Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage rendering GL JS parity For feature parity with Mapbox GL JS labels Jul 10, 2019
@alexshalamov alexshalamov force-pushed the alexshalamov_port_round_line_joins branch from b6af14d to cf245a9 Compare August 4, 2019 08:49
@alexshalamov alexshalamov force-pushed the alexshalamov_port_round_line_joins branch from cf245a9 to 8ada461 Compare August 4, 2019 09:01
@alexshalamov alexshalamov merged commit 5784e32 into master Aug 5, 2019
@alexshalamov alexshalamov deleted the alexshalamov_port_round_line_joins branch August 5, 2019 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mourner mourner mourner approved these changes

Assignees

@alexshalamov alexshalamov

Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS performance Speed, stability, CPU usage, memory usage, or power usage rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Port new round line joins from GL JS
3 participants
@alexshalamov @mourner @friedbunny