This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove stops-based *Function constructors #12258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Jun 29, 2018
|
|
||
| std::unique_ptr<Expression> eq(std::unique_ptr<Expression> lhs, | ||
| std::unique_ptr<Expression> rhs) { | ||
| return std::make_unique<Equals>(std::move(lhs), std::move(rhs), false); |
There was a problem hiding this comment.
This and the other non-compound-expression-based DSL functions bypass type validation. Since the DSL now lowers the barrier to creating expressions directly, without parsing/validation, I think it's worthwhile to include some asserts on the input expressions' types in the various expression constructors.
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove stops-based
*Functionconstructors. Another step towards #11247.