This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
CP master->boba: [core] don't hide icons if text is an empty string #11482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11344. This has been lingering for a while and just (slightly) bit me when I was expecting it to be in boba.
This is the native equivalent of mapbox/mapbox-gl-js#6160 -- not a major bug but something we want to get in nonetheless.
This isn't too late for the next beta of iOS and Android?
/cc @ansis @jfirebaugh @tobrun @friedbunny