fix pinching while touching markers #9683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using e.targetTouches as the list of touches relevant to the map. It contains only the touches that first touched the same target. Touches that hit a marker have a different target. This fixes uses e.touches and filters out touches who's target is not a child of the map. fix #9675
|
Do you think it would be useful to create a page with a high density of randomly placed markers, and add it as part of our release testing here? (making sure we would inevitably touch one while doing a gesture with a density similar to where the issue was shown https://nomadlist.com/map). We already have markers in the list of pages but I have the feeling it would be harder to test that fix from there. |
Yep. The existing marker page might work if you intentionally try to test for this |
karimnaaji
pushed a commit
that referenced
this pull request
May 14, 2020
* fix multi-finger gestures touching markers Previously we were using e.targetTouches as the list of touches relevant to the map. It contains only the touches that first touched the same target. Touches that hit a marker have a different target. This fixes uses e.touches and filters out touches who's target is not a child of the map. fix #9675 * update tests and add regression test
karimnaaji
pushed a commit
that referenced
this pull request
May 14, 2020
* fix multi-finger gestures touching markers Previously we were using e.targetTouches as the list of touches relevant to the map. It contains only the touches that first touched the same target. Touches that hit a marker have a different target. This fixes uses e.touches and filters out touches who's target is not a child of the map. fix #9675 * update tests and add regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9675
When touches touch the markers instead of the canvas they have different targets. Gestures were using
touchEvent.targetTouchesas the list of relevant touches. This broke multi-finger gestures that touch markers.The fix switches to
touchEvent.touchesand filters out touches who's target is not a child element of the map's canvas container.Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix multi-finger gestures that touch markers.</changelog>