Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click Tolerance for Markers #9640

Merged
merged 9 commits into from
Sep 2, 2020
Merged

Click Tolerance for Markers #9640

merged 9 commits into from
Sep 2, 2020

Commits on Apr 28, 2020

  1. add private _clickTolerance property to map 

    This is so that Marker instances can access map._clickTolerance if the Markers do not have their own click tolerances.
    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    f42dc49 View commit details
    Browse the repository at this point in the history

  2. fix flow typing for Marker._positionDelta

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    7158bef View commit details
    Browse the repository at this point in the history

  3. add clickTolerance option to markers 

    If the pointer movement ever exceeds (or equals) click tolerance, then the movement fires drag events, otherwise it fires click events.

Includes getClickTolerance and setClickTolerance methods. Marker clickTolerance is inherited from the map if not provided as an option.
    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    21fc6f4 View commit details
    Browse the repository at this point in the history

  4. fix marker tests after clicktolerance update

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    eebd191 View commit details
    Browse the repository at this point in the history

  5. assert drag handlers do not fire below clicktol

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    c0c29e3 View commit details
    Browse the repository at this point in the history

  6. add tests for getting/setting marker clicktol

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    1f46995 View commit details
    Browse the repository at this point in the history

  7. add pointerEvents assertions to drag tests

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    621bc69 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. reword clickTolerance jsdoc to mirror map option

    @ChristopherChudzicki
    ChristopherChudzicki committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    c69263f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. remove null clickTolerance, remove get/set methods 

     - Make the tolerance numeric instead of ?numeric.
 - 0 marker clickTolerance now inherits from the map
 - remove get/set methods
    @ChristopherChudzicki
    ChristopherChudzicki committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    3688f94 View commit details
    Browse the repository at this point in the history