Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gesture handling refactor #9365

Merged
merged 28 commits into from
Apr 7, 2020
Merged

gesture handling refactor #9365

merged 28 commits into from
Apr 7, 2020

Commits on Apr 1, 2020

  1. Introduce HandlerManager and begin refactoring gestures

    Implement Handler base class & add tests
    
    Implement HandlerManager & add tests
    
    HandlerManager:
    - Keeps track of all handlers
    - Provides high-level handler utility methods
    - Listens for input events on the map
    - Processes input events through all handlers
    - Receives & collates handlers' recommendations
      for map transformations, resolving conflicts
    - Applies map transformations as appropriate
    - Fires output (movement) events as appropriate
    
    [WIP] Replace old handlers/bind_handlers with HandlerManager in Map
    
    Fix touchend case in DOM.touchPos() (touchend may still have touches)
    
    Implement touch handlers
    
    - Add TouchHandler & MultiTouchHandler base classes
    - Implement TouchPan, TouchZoom, TouchRotate, TouchPitch Handlers
    - Add touch handlers to manager by default
    - Add & update tests
    
    Implement inertial easing on moveend; update/add tests
    
    [WIP] Fix some flow errors
    
    Add keydown & keyup events in simulate_interaction.js
    
    Implement KeyboardHandler and add/update tests
    Anjana Vakil authored and ansis committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    223e32e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. refactor gestures

    ansis committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8f37a1a View commit details
    Browse the repository at this point in the history
  2. docs lint

    ansis committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8d43a95 View commit details
    Browse the repository at this point in the history
  3. small fixes

    ansis committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    35a9497 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de96ad0 View commit details
    Browse the repository at this point in the history
  5. fix flow and lint

    ansis committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    fb199ff View commit details
    Browse the repository at this point in the history
  6. fix context menu

    ansis committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    35edf2f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Configuration menu
    Copy the full SHA
    a284c7e View commit details
    Browse the repository at this point in the history
  2. fix test

    ansis committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    cd1c46f View commit details
    Browse the repository at this point in the history
  3. fix keyboard handler

    ansis committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    0d59b5c View commit details
    Browse the repository at this point in the history
  4. lint

    ansis committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    cdc840a View commit details
    Browse the repository at this point in the history
  5. decrease pitch sensitivity

    ansis committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    d3aa25e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. make gestures less sensitive

    - increase allowed tap time diff to 500ms
    - increase rotation threshold slightly
    - add some zoom thresholding (needs more future work)
    ansis committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    a369593 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. add comments

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    78567f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8afa22 View commit details
    Browse the repository at this point in the history
  3. remove comments

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    0eb763f View commit details
    Browse the repository at this point in the history
  4. prefix with _

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    76d7de4 View commit details
    Browse the repository at this point in the history
  5. more prefixing

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    aad0f67 View commit details
    Browse the repository at this point in the history
  6. rename notMoved to moved

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8ff2b1f View commit details
    Browse the repository at this point in the history
  7. rename variable for clarity

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    417d8f2 View commit details
    Browse the repository at this point in the history
  8. remove commented out lines

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    5c74b96 View commit details
    Browse the repository at this point in the history
  9. variable rename

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    b57ca8b View commit details
    Browse the repository at this point in the history
  10. cleanup

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    919f787 View commit details
    Browse the repository at this point in the history
  11. lint

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    87f31a4 View commit details
    Browse the repository at this point in the history
  12. add docs

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9da3c7c View commit details
    Browse the repository at this point in the history
  13. lint docs

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    618aedf View commit details
    Browse the repository at this point in the history
  14. document parameter

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    15a13b5 View commit details
    Browse the repository at this point in the history
  15. lint

    ansis committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9e49d9d View commit details
    Browse the repository at this point in the history