-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gesture handling refactor #9365
Merged
Merged
Commits on Apr 1, 2020
-
Introduce HandlerManager and begin refactoring gestures
Implement Handler base class & add tests Implement HandlerManager & add tests HandlerManager: - Keeps track of all handlers - Provides high-level handler utility methods - Listens for input events on the map - Processes input events through all handlers - Receives & collates handlers' recommendations for map transformations, resolving conflicts - Applies map transformations as appropriate - Fires output (movement) events as appropriate [WIP] Replace old handlers/bind_handlers with HandlerManager in Map Fix touchend case in DOM.touchPos() (touchend may still have touches) Implement touch handlers - Add TouchHandler & MultiTouchHandler base classes - Implement TouchPan, TouchZoom, TouchRotate, TouchPitch Handlers - Add touch handlers to manager by default - Add & update tests Implement inertial easing on moveend; update/add tests [WIP] Fix some flow errors Add keydown & keyup events in simulate_interaction.js Implement KeyboardHandler and add/update tests
Configuration menu - View commit details
-
Copy full SHA for 223e32e - Browse repository at this point
Copy the full SHA 223e32eView commit details
Commits on Apr 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8f37a1a - Browse repository at this point
Copy the full SHA 8f37a1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d43a95 - Browse repository at this point
Copy the full SHA 8d43a95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35a9497 - Browse repository at this point
Copy the full SHA 35a9497View commit details -
Configuration menu - View commit details
-
Copy full SHA for de96ad0 - Browse repository at this point
Copy the full SHA de96ad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb199ff - Browse repository at this point
Copy the full SHA fb199ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35edf2f - Browse repository at this point
Copy the full SHA 35edf2fView commit details
Commits on Apr 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a284c7e - Browse repository at this point
Copy the full SHA a284c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd1c46f - Browse repository at this point
Copy the full SHA cd1c46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d59b5c - Browse repository at this point
Copy the full SHA 0d59b5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc840a - Browse repository at this point
Copy the full SHA cdc840aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3aa25e - Browse repository at this point
Copy the full SHA d3aa25eView commit details
Commits on Apr 6, 2020
-
- increase allowed tap time diff to 500ms - increase rotation threshold slightly - add some zoom thresholding (needs more future work)
Configuration menu - View commit details
-
Copy full SHA for a369593 - Browse repository at this point
Copy the full SHA a369593View commit details
Commits on Apr 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 78567f2 - Browse repository at this point
Copy the full SHA 78567f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8afa22 - Browse repository at this point
Copy the full SHA b8afa22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0eb763f - Browse repository at this point
Copy the full SHA 0eb763fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d7de4 - Browse repository at this point
Copy the full SHA 76d7de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aad0f67 - Browse repository at this point
Copy the full SHA aad0f67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff2b1f - Browse repository at this point
Copy the full SHA 8ff2b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 417d8f2 - Browse repository at this point
Copy the full SHA 417d8f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c74b96 - Browse repository at this point
Copy the full SHA 5c74b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57ca8b - Browse repository at this point
Copy the full SHA b57ca8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 919f787 - Browse repository at this point
Copy the full SHA 919f787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87f31a4 - Browse repository at this point
Copy the full SHA 87f31a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9da3c7c - Browse repository at this point
Copy the full SHA 9da3c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 618aedf - Browse repository at this point
Copy the full SHA 618aedfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15a13b5 - Browse repository at this point
Copy the full SHA 15a13b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e49d9d - Browse repository at this point
Copy the full SHA 9e49d9dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.