Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the Evented parent when removing objects to break GC loop #8813

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Reset the Evented parent when removing objects to break GC loop #8813

merged 1 commit into from
Oct 15, 2019

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Sep 26, 2019

When calling map.remove(), we did try to remove things, but due to circular references, most objects were still retained.

mourner
mourner requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks all our tests — let's make the build green before I review more closely.

@asheemmamoowala asheemmamoowala mentioned this pull request Sep 27, 2019
Closed
@kkaefer kkaefer added this to the release-s milestone Sep 30, 2019
@kkaefer kkaefer requested a review from mourner October 15, 2019 11:54
mourner
mourner approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the build passed apart from that one flaky render test (which I reran).

@kkaefer kkaefer merged commit 4077c78 into master Oct 15, 2019
@kkaefer kkaefer deleted the memory branch October 15, 2019 12:16
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-sangria
Development

Successfully merging this pull request may close these issues.
2 participants
@kkaefer @mourner