Introduce two component text radial offset #8609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
reviewed
Aug 8, 2019
|
cc @mapbox/studio @mapbox/map-design-team @mapbox/gl-native |
|
Is placing around an ellipse what we're looking for? It looks like placing around a rectangle might work better for #8598 |
| // Layers with variable anchors use the `text-radial-offset` property and the [x, y] offset vector | ||
| // is calculated at placement time instead of layout time | ||
| if (radialOffset) { | ||
| if (radialOffset[0]) { |
There was a problem hiding this comment.
This will be false when radialOffset[0] == 0, regardless of radialOffset[1]'s value. This check needs to test both x and y.
|
Closing in favor of #8642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two-component text radial offset for variable text placement. This feature is useful when the text is placed around a symbol icon with different dimensions. The new behavior is described below:
if
text-radial-offsetis initialized with a number (to keep the existing styles working) or with an array of one element, we'll use the circle offset (same way we do now).if
text-radial-offsetis initialized with an array of two elements, these two numbers will stand for the radius on the x and y axes of the ellipse offset.Note: a new
legacy-typefield is added to the specification JSON file in order to allow usage of legacy types - in this particular case we still allow using plainnumbertype with thetext-radial-offset, so that the existing styles remain working.Tagging
@mapbox/studio@mapbox/maps-design@mapbox/gl-nativeFixes #8598