modify setLngLat to instantiate popup element before modifying its classList #8559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8535
This bug occurs when attempting to reposition a marker that has been added to the map, but without a lnglat set.
Because
setLngLat
doesn't create a DOM element forpopup
until near the end of its run, the operation first tries to edit a classList of a nonexistentthis._container
element.This PR modifies
setLngLat
so that it instantiates the DOM element, before modifying its classList.Launch Checklist