Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off 'move' event listeners when removing a marker #8465

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Turn off 'move' event listeners when removing a marker #8465

merged 1 commit into from
Jul 12, 2019

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

fixes #8463

  • briefly describe the changes in this PR
    • it's currently possible to programmatically remove a marker while dragging it which leads to an error because the _onMove event listener is never removed. This fixes that bug.

@ryanhamley ryanhamley requested a review from mourner July 11, 2019 18:29
@ryanhamley ryanhamley mentioned this pull request Jul 11, 2019
Closed
@ryanhamley ryanhamley merged commit 2ce452d into master Jul 12, 2019
@ryanhamley ryanhamley deleted the 8463-draggable-marker-fix branch July 12, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when marker is removed while being dragged
2 participants
@ryanhamley @mourner