Add outline for control buttons while navigating with keyboard #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewharvey
approved these changes
Jul 11, 2019
|
I did notice this, but it's only a minor issue, so I don't mind merging even with this issue. |
|
I also tested this with other controls, MapboxGeocoder, MapboxDirections and this change didn't seem to have any negative effect. |
|
Hey @life777 thanks for bringing up this issue and taking a stab at it. I created a PR #8520 that simulates the outline with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #8246.
If you have some controls on the map (like zoom controls) and you navigate to them with Tab button you couldn't distinguish what button is focused now. This PR adds back an outline for buttons to show what control is focused.
Launch Checklist