Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Popup maxWidth description #8312

Merged
merged 2 commits into from
Jun 4, 2019
Merged

[DOCS] Update Popup maxWidth description #8312

merged 2 commits into from
Jun 4, 2019

Conversation

viniciuskneves
Copy link
Contributor

It updates the maxWidth property description as it accepts not only pixel values but all available max-width CSS values. I've also added the default value to the documentation which was missing.
Also added some small info as a tip to users that want to have a fluid container size.

Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just had a couple minor wording comments

src/ui/popup.js Outdated Show resolved Hide resolved
src/ui/popup.js Outdated Show resolved Hide resolved
@mourner mourner merged commit 16f7de5 into mapbox:publisher-production Jun 4, 2019
@viniciuskneves viniciuskneves deleted the docs/update/popup-maxwidth branch June 4, 2019 09:19
katydecorah pushed a commit that referenced this pull request Jun 13, 2019
* publisher-production:
  [DOCS] Update Popup maxWidth description (#8312)
katydecorah pushed a commit that referenced this pull request Jun 19, 2019
* publisher-production:
  [docs] updates to search component and layout (#8362)
  [docs] adds docs-wide search component (#8349)
  [DOCS] Update Popup maxWidth description (#8312)
  [docs] update docs-page-shell (#8254)
  v1.0.0 (#8277)
  Add sku token to Mapbox API tile requests (#14) (#8276)
  @mapbox/mapbox gl style spec@13.7.0 (#8264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants