Fixes #8256 #8259
Merged
Fixes #8256 #8259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops... linting rules workspace collision... |
|
Huh for some reason I can't get the benchmarks to run, even on master... running out of memory. |
|
nm it worked |
bambielli-flex
commented
May 17, 2019
| @@ -12,7 +12,8 @@ There are two test suites associated with Mapbox GL JS | |||
|
|
|||
| To run individual tests: | |||
|
|
|||
| - Unit tests: `yarn test-unit path/to/file.test.js` where the path begins within the `/test/unit/` directory | |||
| - Unit tests: `yarn test-unit path/to/file.test.js` where path *does not include* `test/unit/` | |||
| - e.g. `yarn test-unit ui/handler/scroll_zoom.test.js` | |||
There was a problem hiding this comment.
I found this instruction confusing, took me a while to realize that I needed to not include /test/unit/ in the test path to be able to run a test.
bambielli-flex
commented
May 17, 2019
| @@ -148,5 +149,93 @@ test('ScrollZoomHandler', (t) => { | |||
| t.end(); | |||
| }); | |||
|
|
|||
| t.test('emits one movestart event and one moveend event while zooming', (t) => { | |||
There was a problem hiding this comment.
I confirmed that these tests would fail on master without the scroll_zoom update.
mourner
approved these changes
May 17, 2019
There was a problem hiding this comment.
I'll let @ryanhamley take a second quick 👀 but this looks great to me! Thanks for the thorough fix with tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
This PR is to fix #8256. By wrapping the movestart event emitter in a check to see if
_zoominghas already started, it will only fire once.This affects both movestart and zoomstart, both of which suffered from the problem outlined in the issue.
document any changes to public APIspost benchmark scores<-- couldn't get these to runtagged@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changestagged@mapbox/gl-nativeif this PR includes shader changes or needs a native port