New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Popup.getElement method (#7425) #8123

Merged

mourner merged 1 commit into mapbox:master from korywka:popup-get-element

Apr 6, 2019

Contributor

korywka commented Apr 4, 2019 •

edited

Loading

Implements #7425

Added test. Previous tests instead of _container use new .getElement. (Like marker test: https://github.com/mapbox/mapbox-gl-js/blob/master/test/unit/ui/marker.test.js#L26 and below)


          Add Popup.getElement method

f0b7351

mourner approved these changes

View reviewed changes

mourner merged commit 9e6c6d9 into mapbox:master

Member

mourner commented Apr 6, 2019

Thanks!

fider mentioned this pull request

mapboxgl Popup getElement is undefined #8827

Closed

andrewharvey mentioned this pull request

Add getElement method to Popup (like Marker) #7425

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet