Update attribution_control.js #8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #8047 Update attribution_control.js optimalization of fix
mourner
requested changes
Mar 26, 2019
change variable names String -> HTML fix linter errors
|
I've changed property names and fixed linter errors. Is it OK now? |
|
Nope, lint still failing. You can check locally by running |
|
Ooops, I am sorry, another attempt. |
fix === linter error, remove unwanted flow monitoring added by linter fix
mourner
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8047
Update attribution_control.js
Launch Checklist
saves previous attribution string and compare it with the new one if there is any change. In case there isn't, attribution string isn't replaced (by
innerHTMLsetter)tested with the extracted build instead of 0.53.1 - number of DOM nodes remains the same
no changes