Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 7944 #7945

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Bugfix 7944 #7945

merged 3 commits into from
Feb 27, 2019

Conversation

sumarlidason
Copy link

@sumarlidason sumarlidason commented Feb 24, 2019 •
edited
Loading

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

Changes

  • logic to disable event reporting when API_URL unrecognized or non-standard
  • implement 4 tests for TurnstileEvent&MapLoadEvent
  • refactor previousUrl out

#7944
cc @mapbox/atlas

Arni Sumarlidason added 3 commits February 23, 2019 10:48
config:: EVENTS_URL does not consider ATLAS / on-premise
c5ecb75 
* provide logic to disable event reporting
* add test

fixes #7944
config:: EVENTS_URL does not consider ATLAS / on-premise
8143f22 
* fix my distracted logic
* add more tests
* add API_URL to beforeEach; remove previousUrl logic

fixes #7944
config:: EVENTS_URL does not consider ATLAS / on-premise
cadba6f 
* remove extraneous console
* improve test names

fixes #7944
@sumarlidason
Copy link
Author

  • Tested locally

Events posted.

image

asheemmamoowala
asheemmamoowala approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sumarlidason sumarlidason merged commit f5c2ae0 into master Feb 27, 2019
@sumarlidason sumarlidason deleted the bugfix_7944 branch February 27, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumarlidason @asheemmamoowala