Return 3d features first from queryRenderedFeatures #7926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ansis |
|
@andycalder thanks for your contribution! I'm going to close this pull request in favor of #7953 which handles some edge cases where fills are above 3D features. Your implementation was how I was expecting this to be fixed but due to some past rendering decisions we needed something more complex. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7883 by returning
fill-extrusionsfirst.fill-extrusionsdon't obey the layer order because they're sorted by depth, and it makes more sense to return them first rather than last.Does this need a unit or integration test? I'd be grateful for some guidance here.