add ondragstart for marker dragging #7799

cs09g · 2019-01-23T00:42:37Z

fix for #7795

Launch Checklist

briefly describe the changes in this PR
manually test the debug page

cs09g · 2019-01-23T02:50:56Z

Oops, Flow type HTMLElement doesn't have ondragstart(declaration).
~~I'll change this to use addEventListener('dragstart', () => false); but it doesn't work as expected with the chages for now.~~
Changed to use preventDefault()

fix for #7795 the first try was using `ondragstart` to prevent all its dragstart but flow type doens't allow it. So, it should be using `addEventListener('dragstart')` and in this case, we can prevent dragstart with `preventDefault()`.

cs09g · 2019-02-19T04:08:44Z

It's ready for review. Could anyone review this please? 😊

ryanhamley

Looks good to me. Thanks!

add ondragstart for marker dragging

1b8c940

fix for #7795 the first try was using `ondragstart` to prevent all its dragstart but flow type doens't allow it. So, it should be using `addEventListener('dragstart')` and in this case, we can prevent dragstart with `preventDefault()`.

ryanhamley approved these changes Feb 19, 2019

View reviewed changes

ryanhamley merged commit 1d7fefd into mapbox:master Feb 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ondragstart for marker dragging #7799

add ondragstart for marker dragging #7799

cs09g commented Jan 23, 2019 •

edited

Loading

cs09g commented Jan 23, 2019 •

edited

Loading

cs09g commented Feb 19, 2019

ryanhamley left a comment

add ondragstart for marker dragging #7799

add ondragstart for marker dragging #7799

Conversation

cs09g commented Jan 23, 2019 • edited Loading

Launch Checklist

cs09g commented Jan 23, 2019 • edited Loading

cs09g commented Feb 19, 2019

ryanhamley left a comment

Choose a reason for hiding this comment

cs09g commented Jan 23, 2019 •

edited

Loading

cs09g commented Jan 23, 2019 •

edited

Loading