Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation option to style setters #7604

Merged
merged 2 commits into from
Nov 26, 2018
Merged

add validation option to style setters #7604

merged 2 commits into from
Nov 26, 2018

Conversation

mollymerp
Copy link
Contributor

Launch Checklist

image

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! The only nit: should we cut out the {validate?: boolean} part into a common ValidateOptions type so that we don't repeat it everywhere? Or maybe something like StylingOptions if we plan to add some non-validation-related options.

@clement-igonet
Copy link

Where can I see "option.validate" documentation nowdays ?
I do not see any reference here: https://docs.mapbox.com/mapbox-gl-js/style-spec/

@ryanhamley
Copy link
Contributor

ryanhamley commented Apr 30, 2020

@clement-igonet This option is for certain setters such as setFilter and the documentation is at the individual method docs, e.g. https://docs.mapbox.com/mapbox-gl-js/api/#map#setfilter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants