Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compact attribution positioning #7445

Merged
merged 2 commits into from
Oct 29, 2018
Merged

fix compact attribution positioning #7445

merged 2 commits into from
Oct 29, 2018

Conversation

mollymerp
Copy link
Contributor

@mollymerp mollymerp commented Oct 19, 2018

fix #7439

image

image

image

note: the 10px margin that the bottom-right compact control has looks odd when applied to the other control locations, so I reduced it to 5px. I would be in favor of making them all consistent at 5px – thoughts?

Launch Checklist

  • briefly describe the changes in this PR
  • manually test the debug page

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The margin inconsistency looks OK to me — I'm fine keeping it this way.

@mollymerp
Copy link
Contributor Author

🤦‍♀️sorry I meant I would be in favor of making them all consistently 5px (edited OP to fix) This is what it looks like:
image

@ryanhamley
Copy link
Contributor

I'm always in favor of symmetry. I think 5px is fine.

@mollymerp
Copy link
Contributor Author

turns out 10px looks better with other controls, so I'm going with that for all positions.

@mollymerp
Copy link
Contributor Author

I ended up switching back to 10px margin because it ends up looking better when using other controls on the map.

@mollymerp mollymerp merged commit 033e3d1 into master Oct 29, 2018
@mollymerp mollymerp deleted the attribution-position branch October 29, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact attribution broken in top-left/top-right locations.
3 participants