make sure worker sends response after reloading 'empty' tile #7355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
commented
Oct 2, 2018
| @@ -110,6 +110,8 @@ class VectorTileWorkerSource implements WorkerSource { | |||
| delete this.loading[uid]; | |||
|
|
|||
| if (err || !response) { | |||
| workerTile.status = 'done'; | |||
| this.loaded[uid] = workerTile; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #7348 to fix #7346 that does not require adding an additional tile
statevalue, and prevents us from guessing whether a reload is necessary based on data returned from the initial worker parse. This is also nice because now the WorkerTile'sloaded:{}object should match the tiles marked asstate: 'loaded'in the foreground.Prior to this, a reload request for a tile that 404'd or otherwise returned no data from the AJAX request would never call its callback and prevented
map.loaded()from ever returningtruedue to tiles hanging withstate: 'reloading'.Launch Checklist
document any changes to public APIspost benchmark scorestagged@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes