fix missing repeats of CanvasSource when it crosses the antimeridian #7273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably a major edge case, but I noticed this behavior while randomly playing around with the map.
In fact, it happens on In normal usage, this PR seems to work like a charm. |
|
@ryanhamley good catch, a54e774 adds a fix for that as well |
ryanhamley
reviewed
Sep 12, 2018
| const utl = this.pointCoordinate(new Point(0, 0), 0); | ||
| const utr = this.pointCoordinate(new Point(this.width, 0), 0); | ||
| const ubl = this.pointCoordinate(new Point(this.width, this.height), 0); | ||
| const ubr = this.pointCoordinate(new Point(0, this.height), 0); |
There was a problem hiding this comment.
Can you explain how this fixes the rotation issue, @ansis?
There was a problem hiding this comment.
Using all four corners is necessary since the leftmost/rightmost points could be any of the corners. The following two lines with the Math.min and Math.max handle the case when the map is upside down
ryanhamley
approved these changes
Sep 12, 2018
ansis
added a commit
that referenced
this pull request
Sep 12, 2018
ryanhamley
pushed a commit
that referenced
this pull request
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7271 by including an extra copy of image sources and canvas sources on either side of the world. In almost all cases this extra copy is necessary, but it shouldn't add any overhead because rendering two offscreen triangles should be negligible.
It might be slightly nicer to have an approach that actually calculates how many copies we need to render but I think this would be significantly more complex and probably slower.
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes