Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["to-array", <item type>, <empty array>] should work for any item type #7261

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

jfirebaugh
Copy link
Contributor

Previously it was a type error because the runtime type of an empty array is inferred as array<value, 0>.

Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Is there a similar issue that needs ticketing on native?

@jfirebaugh
Copy link
Contributor Author

Yeah, there are several changes that need porting; I'll do them all at once and roll into mapbox/mapbox-gl-native#12864.

@jfirebaugh jfirebaugh merged commit 64c2538 into master Sep 11, 2018
@jfirebaugh jfirebaugh deleted the to-array-empty branch September 11, 2018 20:15
jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Sep 11, 2018
jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Sep 13, 2018
jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants