Convert offsetHeight/Width to clientHeight/Width #7128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
added
the
breaking change ⚠️
mourner
reviewed
Aug 14, 2018
src/ui/popup.js
Outdated
| const width = this._container.offsetWidth; | ||
| const height = this._container.offsetHeight; | ||
| const width = this._container.clientWidth; | ||
| const height = this._container.clientHeight; |
There was a problem hiding this comment.
This is measuring the popup's container rather than the map one, and we might want to leave offset sizes here, since for positioning the popup, it's important to take the whole popup into account (including borders/etc) rather than just its internal area.
There was a problem hiding this comment.
I reverted popups and the attribution and logo controls to use offsetWidth/Height
mourner
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
offset{Height/Width}toclient{Height/Width}master with offset{Height/Width}canvas-hw with client{Height/Width}