Fix querySourceFeatures returning bad results on zooms past maxZoom #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
reviewed
Aug 2, 2018
src/geo/transform.js
Outdated
| @@ -248,7 +246,7 @@ class Transform { | |||
| this.pointCoordinate(new Point(this.width, this.height), z), | |||
| this.pointCoordinate(new Point(0, this.height), z) | |||
| ]; | |||
| return tileCover(z, cornerCoords, options.reparseOverscaled ? actualZ : z, this._renderWorldCopies) | |||
There was a problem hiding this comment.
Does this work for raster sources past their max zoom level? I think the previous behaviour was that it used the existing tiles from the max zoom level. Does this end up creating new tiles?
mourner
force-pushed
the
no-reparse-overscaled
branch
from
6222c85
to
326eed6
Compare
|
I also noticed (after the PR) that #4990 inadvertently contains the same fix. Sorry for not noticing earlier @asheemmamoowala! |
|
I'm not sure that this fixes #3722 it sets reparseOverscaled to true, which seemingly does the opposite as the geometries coming back at zoom levels greater than 16 are still wrong |
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2868. Fixes #3722.
I also removed thereparseOverscaledsource option because it doesn't seem useful — we always want to reparse overscaled tiles for correct layout values, and we don't need to worry about performance because parsing overscaled tiles is very fast anyway (there's only a few on the screen and they're small).Launch Checklist
document any changes to public APIspost benchmark scores