Don't default-show text/icons that depend on the placement of a paired icon/text. #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d icon/text. Fixes issue #7032.
ansis
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
We could potentially get a little finer grained and check where there was paired icon/text at the per-symbol level instead of the per-bucket level, but it'd be extra work in performance sensitive code and all it would get you is that in a few situations you'd be able to start showing a symbol a little bit earlier.
Your approach seems good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7032.
We could potentially get a little finer grained and check where there was paired icon/text at the per-symbol level instead of the per-bucket level, but it'd be extra work in performance sensitive code and all it would get you is that in a few situations you'd be able to start showing a symbol a little bit earlier.
document any changes to public APIstagged@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes/cc @ansis @RomainQuidet