Require feature id in Map#setFeatureState

[asheemmamoowala]

Map#setFeatureState should validate the input feature identifier object for the id field, in addition to source and sourceLayer.

[ryanhamley]

What happens if you pass an undefined value or empty string as the feature id? Is that considered valid?

[asheemmamoowala]

== null works for undefined and null, but not for "". Ive added that additional check. Using === isn't appropriate here because 0 is a valid id value.

[ryanhamley]

👍 good explanation

[strech345]

does setFeatureState only works if the id-propertyname is "id"? whats happend if it is a different name?

[asheemmamoowala]

@strech345 the id field required for this API is the top level feature.id field, not one of the fields in its property collection (feature.propertis.id).

[strech345]

@asheemmamoowala
thanks. and how to create mbtiles with id by using tippicanoe? Do i only need a geojson which does have the id property?

[asheemmamoowala]

@strech345 -> mapbox/tippecanoe#614

[e-n-f]

mapbox/tippecanoe#615 adds the most basic --generate-ids option (using the input feature sequence for the ID), with the disclaimer that the IDs are not stable and that their format may change in the future.