Fix flyTo not zooming to exact given zoom #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
approved these changes
Jun 18, 2018
|
@andrewharvey great, I didn't realize that was already reported. @mollymerp I couldn't come up with a comment that would make the lines clearer... |
|
oh I was just thinking something like "avoid floating point errors by using zoom directly when (whatever k represents) |
This was referenced Aug 30, 2018
mourner
pushed a commit
that referenced
this pull request
Sep 4, 2018
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 15, 2019
…7222) (mapbox#7223) * Fix flyTo when final zoom is not requested one (mapbox#7222) This complete the fix for mapbox#6828 when the final zoom value is different from the zoom requested. * Fix final center position and add test case.
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 16, 2019
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 16, 2019
…7222) (mapbox#7223) * Fix flyTo when final zoom is not requested one (mapbox#7222) This complete the fix for mapbox#6828 when the final zoom value is different from the zoom requested. * Fix final center position and add test case.
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
…7222) (mapbox#7223) * Fix flyTo when final zoom is not requested one (mapbox#7222) This complete the fix for mapbox#6828 when the final zoom value is different from the zoom requested. * Fix final center position and add test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you call
flyTowith an integerzoom, you're not guaranteed to land on the exact zoom after the animation because of floating point errors. E.g.map.flyTo({zoom: 2})when starting on zoom 0.6 will end up on zoom1.999999999996, which is problematic if you wish to get on the exact zoom for corresponding tiles to load. Discovered this while implementing thegetClusterExpansionZoomAPI.Launch Checklist
document any changes to public APIspost benchmark scorescloses #6191