fix zero-width line rendering #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Jun 1, 2018
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 14, 2019
* fix zero-width line rendering * fix other line types too:
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
* fix zero-width line rendering * fix other line types too:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6769
we return early and abort the whole draw call if
line-widthis constant at 0, but also had to modify the shader in case aline-widthexpression evaluates to 0cc @peterqliu
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes