Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch gl-matrix fork in favor of the original package #6751

Merged
merged 2 commits into from
May 29, 2018
Merged

Ditch gl-matrix fork in favor of the original package #6751

merged 2 commits into from
May 29, 2018

Conversation

mourner
Copy link
Member

@mourner mourner commented May 29, 2018

Ditches our fork (@mapbox/gl-matrix) in favor of the original package, gl-matrix, which got fully modernized. Combined with treeshaking by Rollup, it makes the fork obsolete. Made sure the build size doesn't increase.

@mourner mourner requested a review from anandthakker May 29, 2018 15:55
jfirebaugh
jfirebaugh approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the glmatrix license from LICENSE.txt as well -- it was copied in back when we had a vendored copy of glmatrix.

@mourner mourner merged commit 5c06295 into master May 29, 2018
@mourner mourner deleted the update-gl-matrix branch May 29, 2018 16:25
@embrenneke embrenneke mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

@anandthakker anandthakker Awaiting requested review from anandthakker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mourner @jfirebaugh