Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "crossSourceCollisions" option to restore per-source collision detection #6566

Merged
merged 5 commits into from
Jun 8, 2018
Merged

Add "crossSourceCollisions" option to restore per-source collision detection #6566

merged 5 commits into from
Jun 8, 2018

Commits on May 29, 2018

  1. Make GridIndex query calls take an optional predicate that can filter… 

    … against the content of keys.
    @ChrisLoer
    ChrisLoer committed May 29, 2018
    Configuration menu
    Copy the full SHA
    69960eb View commit details
    Browse the repository at this point in the history

  2. Introduce "collision groups": collision detection happens within grou… 

    …ps but not between them.
    @ChrisLoer
    ChrisLoer committed May 29, 2018
    Configuration menu
    Copy the full SHA
    14d740e View commit details
    Browse the repository at this point in the history

  3. Render tests for text-collision-group and icon-collision-group.

    @ChrisLoer
    ChrisLoer committed May 29, 2018
    Configuration menu
    Copy the full SHA
    4f920a5 View commit details
    Browse the repository at this point in the history

  4. Remove icon/text-collision-group from style spec. 

    Re-implement basic collision group support based on a global "crossSourceCollisions" map option that replicates pre-#5150 behavior.
Render tests maintain the same structure/results, but are now based on grouping-by-source.
    @ChrisLoer
    ChrisLoer committed May 29, 2018
    Configuration menu
    Copy the full SHA
    1ea1c4a View commit details
    Browse the repository at this point in the history

  5. "collision group" -> "cross source collisions" conversion: 

     - Rename tests
 - Remove dead code from CollisionGroups, update parameter names
 - Simplify return pathways for _query
    @ChrisLoer
    ChrisLoer committed May 29, 2018
    Configuration menu
    Copy the full SHA
    e9dd1b9 View commit details
    Browse the repository at this point in the history