Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add className option to Popup constructor #6502

Merged
merged 1 commit into from
Apr 30, 2018
Merged

add className option to Popup constructor #6502

merged 1 commit into from
Apr 30, 2018

Conversation

Ashot-KR
Copy link
Contributor

Add className option to Popup constructor, so it will be able to create themes for popups with ease.

Example

var popup = new mapboxgl.Popup({
  className: 'some custom classes'
});

Related to #6299

@Ashot-KR Ashot-KR mentioned this pull request Apr 12, 2018
Closed
jfirebaugh
jfirebaugh approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jfirebaugh jfirebaugh merged commit 7419c60 into mapbox:master Apr 30, 2018
@damienalexandre damienalexandre mentioned this pull request May 31, 2018
Closed
@Ashot-KR Ashot-KR deleted the popup-className-option branch September 11, 2019 07:36
@PterPmnta
Copy link

How does this work? I had been trying to use my own classes, but these don't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashot-KR @PterPmnta @jfirebaugh