Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax type checking for "length" #6244

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Relax type checking for "length" #6244

merged 1 commit into from
Feb 28, 2018

Conversation

jfirebaugh
Copy link
Contributor

Fixes #6006 by accepting arguments of type value and performing runtime type checking.

mollymerp
mollymerp approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I don't have a ton of familiarity w the expression definition area of the codebase but the new length seems to adhere to existing conventions.

🎉 for less burden on developers/expression writers.

@jfirebaugh jfirebaugh merged commit ebe47a4 into master Feb 28, 2018
@jfirebaugh jfirebaugh deleted the fix-6006 branch February 28, 2018 00:19
@jfirebaugh jfirebaugh added this to the 0.45.0 milestone Feb 28, 2018
This was referenced Mar 1, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @mollymerp