Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reuse Map#{moving,zooming} state #6183

Merged
merged 3 commits into from
Feb 17, 2018
Merged

Don't reuse Map#{moving,zooming} state #6183

merged 3 commits into from
Feb 17, 2018

Commits on Feb 17, 2018

  1. Don't reuse Map#{moving,zooming} state 

    Instead, implement isMoving and isZooming using the independent state that the relevant handlers already track.
    @jfirebaugh
    jfirebaugh committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    105eaea View commit details
    Browse the repository at this point in the history

  2. Add isRotating(), _-prefix private properties

    @jfirebaugh
    jfirebaugh committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    9a4bfec View commit details
    Browse the repository at this point in the history

  3. Add a test for isZooming on double click

    @jfirebaugh
    jfirebaugh committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    a0b86f7 View commit details
    Browse the repository at this point in the history