Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collision detection perspective ratios #5913

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Fix collision detection perspective ratios #5913

merged 2 commits into from
Jan 3, 2018

Commits on Jan 2, 2018

  1. Fix perspective ratios: 

     - Box and circle collision detection were using incorrectly inverted perspective ratios. [(1/(.5 + .5 * y/x) instead of (.5 + .5 * x/y)].
 - Debug circles were using the same incorrect ratio (so they matched actual collision detection)
 - pixelsToTileUnits incorrectly included perspective ratio: it's used for measuring geometry, not text, so "scale" is relevant but "perspective ratio" isn't.

'collision-pitched-lines' exposed the behavior, but it was too complicated a test for us to be able to understand the problem.
    @ChrisLoer
    ChrisLoer committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    8b7f390 View commit details
    Browse the repository at this point in the history

  2. Regression test for issue #5911.

    @ChrisLoer
    ChrisLoer committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    3d7201f View commit details
    Browse the repository at this point in the history