Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Color#toString, expose Color publicly, document it #5866

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Add Color#toString, expose Color publicly, document it #5866

merged 2 commits into from
Dec 14, 2017

Conversation

davidtheclark
Copy link
Contributor

@jfirebaugh We chatted earlier today about converting Color instances to rgba strings.

  • Adds Color#toString.
  • Exposes the Color class publicly.
  • Documents the Color class.

Here are screenshots of the documentation:

screen shot 2017-12-14 at 1 39 20 pm

screen shot 2017-12-14 at 1 39 25 pm

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs

jfirebaugh
jfirebaugh approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This uncovered some premultiplication-related bugs in the implementation of the rgba and to-rgba expression operators.

@jfirebaugh jfirebaugh merged commit 4a4f1ff into master Dec 14, 2017
@jfirebaugh jfirebaugh deleted the stringify-colors branch December 14, 2017 22:25
@jfirebaugh jfirebaugh mentioned this pull request Dec 14, 2017
Merged
@jfirebaugh jfirebaugh mentioned this pull request Jan 8, 2018
Merged
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtheclark @jfirebaugh