Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-fading of *-pattern and line-dasharray #5791

Merged
merged 7 commits into from
Dec 4, 2017
Merged

Fix cross-fading of *-pattern and line-dasharray #5791

merged 7 commits into from
Dec 4, 2017

Commits on Dec 1, 2017

  1. Extract some SymbolBucket properties that are needed only temporarily 

    This saves needing to serialize these properties.
    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    1c178c7 View commit details
    Browse the repository at this point in the history

  2. Combine Style#{update,_recalculate}

    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    26d2df5 View commit details
    Browse the repository at this point in the history

  3. Push parameters up

    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    f94e495 View commit details
    Browse the repository at this point in the history

  4. Extract ZoomHistory class

    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    aaf815b View commit details
    Browse the repository at this point in the history

  5. Extract EvaluationParameters class

    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    1b88c8e View commit details
    Browse the repository at this point in the history

  6. Don't include _placementDirty in loaded() 

    loaded() is an indication of data completeness, not rendering quiescence. Transitory effects (transitions, cross-fading, collision fading) are not included by design.
    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    56173f3 View commit details
    Browse the repository at this point in the history

  7. Fix cross-fading of *-pattern and line-dasharray

    @jfirebaugh
    jfirebaugh committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    1ac4a0c View commit details
    Browse the repository at this point in the history