Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaN as input to step and interpolate expressions #5757

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Handle NaN as input to step and interpolate expressions #5757

merged 1 commit into from
Nov 28, 2017

Conversation

anandthakker
Copy link
Contributor

Closes #4172

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

mollymerp
mollymerp approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍏

@anandthakker anandthakker merged commit fa136eb into master Nov 28, 2017
@anandthakker anandthakker deleted the fix-4172 branch November 28, 2017 18:57
@jfirebaugh jfirebaugh mentioned this pull request Dec 2, 2017
Closed
@jfirebaugh jfirebaugh mentioned this pull request Dec 14, 2017
Merged
@jfirebaugh jfirebaugh mentioned this pull request Jan 10, 2018
Merged
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandthakker @jfirebaugh @mollymerp