Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate container option #5695

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Validate container option #5695

merged 2 commits into from
Nov 21, 2017

Conversation

jingsam
Copy link
Contributor

@jingsam jingsam commented Nov 17, 2017

No description provided.

@jingsam
Copy link
Contributor Author

jingsam commented Nov 17, 2017

Relate to #5635

@jingsam jingsam mentioned this pull request Nov 17, 2017
Closed
5 tasks
@jingsam
Copy link
Contributor Author

jingsam commented Nov 18, 2017

Seems lead to wrong way. Shall I import HTMLElement from util/window.js

@mollymerp
Copy link
Contributor

Yes, I believe importing HTMLElement will fix it @jingsam

mollymerp
mollymerp approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jingsam!

@mollymerp mollymerp merged commit 3a0af63 into mapbox:master Nov 21, 2017
@jfirebaugh jfirebaugh mentioned this pull request Nov 21, 2017
Merged
@jingsam jingsam deleted the validate-container-option branch November 27, 2017 11:41
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jingsam @mollymerp